I wouldn’t necessarily fail a site for using frames if they did it well, but I have to say that hasn’t come up yet

Yeah, there’s plenty of things – like using frames – that don’t by themselves mean a site will be inaccessible but you shudder when you see them because you know all your past experience tends to indicate an uh-oh…